Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[FEATURE] add server reflection support for grpc server #1181
Comments
This comment has been minimized.
This comment has been minimized.
not so simple as looks before: if we fill response with valid data all stuff works fine with it |
This comment has been minimized.
This comment has been minimized.
mostly we need to do copy/paste https://github.com/grpc/grpc-go/blob/master/reflection/serverreflection.go |
This comment has been minimized.
This comment has been minimized.
Now that's interesting. I did not know that we could hack around the problem with this. An interesting solution. How much effort to do you think it is to add this by default to all services? We could add in server/grpc where we do extraction, have a reflection.go file for it? |
This comment has been minimized.
This comment has been minimized.
I think that this is must be option to server. Because it adds additional handler to it. And also may be used to abuse it or something bad. Mostly we can add reflection.go file and slightly modify it for our use-case |
This comment has been minimized.
This comment has been minimized.
So |
This comment has been minimized.
This comment has been minimized.
yes, probably |
This comment has been minimized.
This comment has been minimized.
Consider adding an option for exposing grpc.Server, it will help us do more about things, such as registering prometheus, reflection, health etc.. |
This comment has been minimized.
This comment has been minimized.
we don't plan to leak abstraction and expose grpc.Server |
vtolstov commentedFeb 10, 2020
Is your feature request related to a problem? Please describe.
Add ability to use with micro grpc service standalone grpc tools like web ui or grpc curl
Describe the solution you'd like
https://github.com/grpc/grpc-go/blob/master/Documentation/server-reflection-tutorial.md#enable-server-reflection
Additional context
simple change, needs to investigate drawbacks