Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.22 does not have a 'ShaderCore' Module. fix plz #248

Open
kklimitkk opened this issue Apr 10, 2019 · 5 comments
Open

4.22 does not have a 'ShaderCore' Module. fix plz #248

kklimitkk opened this issue Apr 10, 2019 · 5 comments

Comments

@kklimitkk
Copy link

@kklimitkk kklimitkk commented Apr 10, 2019

1>UnrealBuildTool : error : Could not find definition for module 'ShaderCore'
(referenced via Target -> JavascriptUMG.Build.cs)

@crocuis

This comment has been minimized.

Copy link
Contributor

@crocuis crocuis commented Apr 10, 2019

you should checkout 4.22 branch :)

@kklimitkk

This comment has been minimized.

Copy link
Author

@kklimitkk kklimitkk commented Apr 10, 2019

Thank you @crocuis

yes, I checkout 4.22 branch, but 'Engine/Source/Runtime/ShaderCore' isn't exist.
4.21 Engine/Runtime/ShaderCore
4.22 Engine/Runtime/ShaderCore
4.22 Engine/Runtime

it seems like shader core has been merged into render core.

should i remove 'ShaderCore' of JavascriptUMG.Build.cs ?

@crocuis

This comment has been minimized.

Copy link
Contributor

@crocuis crocuis commented Apr 10, 2019

https://github.com/ncsoft/Unreal.js-core/blob/4.22/Source/JavascriptUMG/JavascriptUMG.Build.cs

In this code, there is no code to add a ShaderCore. The code using ShaderCore was used in 4.21 and removed in 4.22.

@crocuis

This comment has been minimized.

Copy link
Contributor

@crocuis crocuis commented Apr 10, 2019

I said that you should checkout the branch of Unreal.js to 4.22.

@kklimitkk

This comment has been minimized.

Copy link
Author

@kklimitkk kklimitkk commented Apr 10, 2019

oh god, thank you very much @crocuis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.