Skip to content

/ flutter

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation broken link to fast_linear_to_slow_ease_in.mp4 #52316

Open
md-weber opened this issue Mar 10, 2020 · 3 comments
Open

Documentation broken link to fast_linear_to_slow_ease_in.mp4 #52316

md-weber opened this issue Mar 10, 2020 · 3 comments
Labels
a: animation documentation easy fix framework

Comments

@md-weber
Copy link

@md-weber md-weber commented Mar 10, 2020

In Curves.dart there is a broken Link to a specific video.
https://flutter.github.io/assets-for-api-docs/assets/animation/fast_linear_to_slow_ease_in.mp4

  /// A curve that is very steep and linear at the beginning, but quickly flattens out
  /// and very slowly eases in.
  ///
  /// By default is the curve used to animate pages on iOS back to their original
  /// position if a swipe gesture is ended midway through a swipe.
  ///
  /// {@animation 464 192 https://flutter.github.io/assets-for-api-docs/assets/animation/fast_linear_to_slow_ease_in.mp4}
  static const Cubic fastLinearToSlowEaseIn = Cubic(0.18, 1.0, 0.04, 1.0);
@Zazo032

This comment has been minimized.

Sign in to view
Copy link
Contributor

@Zazo032 Zazo032 commented Mar 10, 2020

The valid url is https://github.com/flutter/assets-for-api-docs/blob/master/assets/animation/curve_fast_linear_to_slow_ease_out.mp4
@HansMuller HansMuller added the easy fix label Mar 10, 2020
@JosepBove

This comment has been minimized.

Sign in to view
Copy link
Contributor

@JosepBove JosepBove commented Mar 12, 2020 •
edited

The valid url should be https://flutter.github.io/assets-for-api-docs/assets/animation/curve_fast_linear_to_slow_ease_in.mp4 , which means that just the curve_ prefix is missing.

I am going to create a pull request in the repository of the generator because it creates the file with a wrong name and also create a commit here at flutter to update the docs!
JosepBove added a commit to JosepBove/flutter that referenced this issue Mar 12, 2020
@JosepBove
Correct broken link
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8c14e9a 
A link was broken as said in flutter#52316
This was referenced Mar 12, 2020
Merged
Merged
@JosepBove

This comment has been minimized.

Sign in to view
Copy link
Contributor

@JosepBove JosepBove commented Mar 12, 2020 •
edited

There is also an error here because the prefix curve_ is missing

  /// A cubic animation curve that starts linearly and ends slowly.
  ///
  /// A symmetric animation to [easeInToLinear].
  ///
  /// {@animation 464 192 https://flutter.github.io/assets-for-api-docs/assets/animation/linear_to_ease_out.mp4}
  static const Cubic linearToEaseOut = Cubic(0.35, 0.91, 0.33, 0.97);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: animation documentation easy fix framework
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@md-weber @Zazo032 @JosepBove @HansMuller @TahaTesser
You can’t perform that action at this time.